arm: mvebu: Various mvebu clock fixes/improvements

Andrew Lunn andrew at lunn.ch
Tue Nov 20 04:43:45 EST 2012


On Tue, Nov 20, 2012 at 10:40:42AM +0100, Thomas Petazzoni wrote:
> Andrew,
> 
> On Mon, 19 Nov 2012 19:27:01 +0100, Andrew Lunn wrote:
> 
> > > In summary:
> > > 
> > >  * Patch 1 fixes a real problem: the gating clocks are not registered
> > >    on Armada 370/XP.
> > > 
> > >  * Patch 2, 3, 5 and 6 are more cosmetic patches, but I think they are
> > >    good to have.
> > > 
> > >  * Patch 4 implements a fix that we've been discussing: moving the
> > >    Armada XP CPU clocks down to the individual armada-xp-mv78xxx.dtsi
> > >    files.
> > > 
> > >  * Patch 7 fixes the references to the SATA clocks on Armada
> > >    370/XP. Without this patch, Armada 370 currently hangs at boot when
> > >    trying to initialize SATA.
> > 
> > Hi Thomas
> > 
> > You probably want patch 1 last. Anybody bisecting this changeset if
> > going to have a hung 370/XP.
> 
> Unfortunately, I don't think putting patch 1 last will work either: in
> patch 7, I change the SATA clocks to point to the gating clocks. So if
> patch 1 is not there, those clocks do not exist and the driver fails to
> clk_get() those clocks.

I don't think that is fatal. Orion5x does not have those clocks. The
PCI version of the SATA devices also does not have those clocks.

    Andrew



More information about the linux-arm-kernel mailing list