[PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata

Greg KH gregkh at linuxfoundation.org
Fri Nov 16 07:02:34 EST 2012


On Fri, Nov 16, 2012 at 12:06:57PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik <m.grzeschik at pengutronix.de> writes:
> 
> > From: Marc Kleine-Budde <mkl at pengutronix.de>
> >
> > Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> > Signed-off-by: Michael Grzeschik <m.grzeschik at pengutronix.de>
> 
> static yes, __devinitdata -- probably not. These structs are used
> everywhere throughout the driver currently, not only at initialization
> time.

__devinitdata means nothing anymore given that CONFIG_HOTPLUG is always
enabled.  It also will probably be removed for 3.8, so don't even worry
about adding these types of markings to variables.

thanks,

greg k-h



More information about the linux-arm-kernel mailing list