[PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver

Linus Walleij linus.walleij at linaro.org
Thu Nov 15 14:09:20 EST 2012

On Thu, Nov 15, 2012 at 3:19 PM, Viresh Kumar <viresh.kumar at linaro.org> wrote:
> On 15 November 2012 19:47, Linus Walleij <linus.walleij at linaro.org> wrote:

>> Just one question: since this driver is not using any
>> pinctrl interfaces, why is it under drivers/pinctrl/*?
>> Shouldn't it be under drivers/gpio from a technical
>> point of view?
>> I think I'd accept it under drivers/pinctrl/spear/*
>> if you just want this to keep everything SPEAr-related
>> in one place though, so enlighten me.
> That's because they are controlling few pads. They are not
> actually gpio's but just pads that we are controlling.
> That's why we thought they are better in this place.

The grouping of drivers in the kernel is about what in-kernel
subsystem interface they're using, not how their electronics

Since this driver is only using the GPIO API it should be
in drivers/gpio/gpio-*.c.

Many, many drivers in drivers/gpio* are controlling pads
too, so it will be in good company ;-)

Linus Walleij

More information about the linux-arm-kernel mailing list