[PATCH] ARM i.MX dts: Consistently add labels to devicenodes
Shawn Guo
shawn.guo at linaro.org
Thu Nov 15 09:10:44 EST 2012
On Thu, Nov 15, 2012 at 02:30:34PM +0100, Sascha Hauer wrote:
> On Thu, Nov 15, 2012 at 09:48:33PM +0800, Shawn Guo wrote:
> > On Thu, Nov 15, 2012 at 09:31:52AM +0100, Sascha Hauer wrote:
> > > Having labels before each node allows board bindings to reference
> > > to nodes by using the &nodename {} notation.
> >
> > I can understand this part.
> >
> > > This way boards do not
> > > have to resemble the whole devicetree layout. Due to less indention
> > > needed the board files also get better readability.
> >
> > I do not understand it. Don't we have to always maintain the device
> > tree layout defined by <soc>.dtsi in <board>.dts, do we?
>
> Have a look at for example arch/arm/boot/dts/omap5-evm.dts, it is
> written like this:
>
> ...
>
> &mmc1 {
> vmmc-supply = <&vmmcsd_fixed>;
> bus-width = <4>;
> };
>
> &mmc2 {
> vmmc-supply = <&vmmcsd_fixed>;
> bus-width = <8>;
> ti,non-removable;
> };
>
> &mmc3 {
> bus-width = <4>;
> ti,non-removable;
> };
>
> ...
>
> I've written some board dts from scratch yesterday and this is much
> easier to write (and I think also easier to read as I don't have to
> care about the tree layout when writing a dts).
>
Ah, ok. I do not know this syntax before. Thanks. Just applied the
patch.
Shawn
More information about the linux-arm-kernel
mailing list