Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

Srinidhi Kasagar srinidhi.kasagar at stericsson.com
Thu Nov 15 04:57:42 EST 2012


On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
> 
> > > -       if (timeout < 0) {
> > > -               dev_err(&dev->adev->dev,
> > > -                       "wait_for_completion_timeout "
> > > -                       "returned %d waiting for event\n", timeout);
> > > -               status = timeout;
> > > -       }
> > > -
> > No, it is wrong. You need to update the status variable in the case of timeout.
> 
> Looking at the patch context, such code comes later.
But it causes regressions; without looking at the "later" code, we can't afford merging
this code now.

regards/srinidhi



More information about the linux-arm-kernel mailing list