[PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

Alexander Shishkin alexander.shishkin at linux.intel.com
Wed Nov 14 08:32:36 EST 2012


Michael Grzeschik <mgr at pengutronix.de> writes:

> On Wed, Nov 14, 2012 at 03:25:30PM +0200, Alexander Shishkin wrote:
>> Michael Grzeschik <m.grzeschik at pengutronix.de> writes:
>> 
>> > This driver will be used for every Freescale SoC which has this misc
>> > memory layout to control the basic usb handling. So better name this
>> > driver, function and struct names in a more generic way.
>> >
>> > Reported-by: Fabio Estevam <festevam at gmail.com>
>> > Signed-off-by: Michael Grzeschik <m.grzeschik at pengutronix.de>
>> > Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
>> > ---
>> >  drivers/usb/chipidea/usbmisc_imx.c   |  163 ++++++++++++++++++++++++++++++++++
>> >  drivers/usb/chipidea/usbmisc_imx6q.c |  163 ----------------------------------
>> >  2 files changed, 163 insertions(+), 163 deletions(-)
>> >  create mode 100644 drivers/usb/chipidea/usbmisc_imx.c
>> >  delete mode 100644 drivers/usb/chipidea/usbmisc_imx6q.c
>> 
>> Like Fabio suggested already, please use rename detection.
>> Another thing, how do you get away with this without fixing the Makefile
>> accordingly? Did you (at least) compile-test this patchset?
>
> You are right, i have compile tested this patchset before adding this
> patch. Sorry for that, i will test the whole series again on my
> platform (mx53), before sending v2.

Thanks!

Regards,
--
Alex



More information about the linux-arm-kernel mailing list