[PATCH 1/6] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

Alexander Shishkin alexander.shishkin at linux.intel.com
Wed Nov 14 08:22:46 EST 2012


Michael Grzeschik <m.grzeschik at pengutronix.de> writes:

> From: Marc Kleine-Budde <mkl at pengutronix.de>
>
> While there fix a potential race condition, first set usbmisc, then call
> usbmisc_set_ops().

This should be really two separate patches, both of which could use
more elaborate commit messages. That is, if you unset variable, what
kind of scenario it prevents, what exactly is the potential race
condition, etc. Saves time for everybody.

>
> Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> Signed-off-by: Michael Grzeschik <m.grzeschik at pengutronix.de>
> ---
>  drivers/usb/chipidea/usbmisc_imx6q.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

I'd also move the renaming patch in front of everything else, but that's
up to you.

Regards,
--
Alex



More information about the linux-arm-kernel mailing list