[PATCH] Revert "ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints"

Jean Pihet jean.pihet at newoldbits.com
Wed Nov 14 06:00:39 EST 2012


Hi Wolfram,

On Wed, Nov 14, 2012 at 11:51 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
> On Tue, Nov 06, 2012 at 04:31:32PM +0000, Paul Walmsley wrote:
>>
>> This reverts commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc.
>
> Here giving the patch name in parens would have really made sense.
> Will fix that.
The title is "ARM: OMAP: convert I2C driver to PM QoS for MPU latency
constraints".

>
>> This commit causes I2C timeouts to appear on several OMAP3430/3530-based
>> boards:
>>
>>   http://marc.info/?l=linux-arm-kernel&m=135071372426971&w=2
>>   http://marc.info/?l=linux-arm-kernel&m=135067558415214&w=2
>>   http://marc.info/?l=linux-arm-kernel&m=135216013608196&w=2
There is no formal piecof evidence that the commit is the cause of it.

>>
>> and appears to have been sent for merging before one of its prerequisites
>> was merged:
However this is correct. My fault ;-|

>>
>>   http://marc.info/?l=linux-arm-kernel&m=135219411617621&w=2
>
> Hmm, any ideas how to avoid such things in the future?
The only way is to figure out the dependencies with other features. In
this case I overlooked them and assumed some other features were
already merged in. Will take care next time.

>
>> Signed-off-by: Paul Walmsley <paul at pwsan.com>
>
> Applied to for-current, thanks!

Thanks!
Jean

>
> --
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list