[PATCH v2] Add support for generic BCM SoC chipsets

Christian Daudt csd at broadcom.com
Tue Nov 13 12:58:13 EST 2012


On 12-11-12 07:17 AM, Russell King - ARM Linux wrote:
> On Sun, Nov 11, 2012 at 06:57:14AM -0800, Christian Daudt wrote:
>> +#include <linux/of_irq.h>
>> +#include <linux/of_platform.h>
>> +#include <linux/init.h>
>> +#include <linux/device.h>
>> +#include <linux/platform_device.h>
>> +#include <asm/io.h>
> Please use linux/io.h rather than asm/io.h throughout your patch sets.
> However, I don't see anything in this file which requires this header,
> so it's better off being removed entirely.
>
that will be required later, but you're right. It is not being used at 
this point so I've removed it.
  thanks,
    csd





More information about the linux-arm-kernel mailing list