[PATCH v4 4/9] ARM: dts: support pinctrl single in pxa910
Tony Lindgren
tony at atomide.com
Fri Nov 9 17:48:21 EST 2012
Hi,
To clarify my binding change comment for the generic pinconf
support, here's an example.
We need to move pinctrl-single pinconf properties here for
each pin group:
* Haojian Zhuang <haojian.zhuang at gmail.com> [121107 07:21]:
> + uart1_pins: pinmux_uart1_pins {
> + pinctrl-single,pins = <
> + 0x198 0x6 /* GPIO47_UART1_RXD */
> + 0x19c 0x6 /* GPIO48_UART1_TXD */
> + >;
> + pinctrl-single,power-source = <0x2>;
> + pinctrl-single,bias = <0x6>;
pinctrl-single,power-source-mask = <0x1800>;
pinctrl-single,bias-mask = <0xe000>;
pinctrl-single,bias-disable = <0>;
pinctrl-single,bias-pull-down = <0xa000>;
pinctrl-single,bias-pull-up = <0xc000>;
> + };
> --- a/arch/arm/boot/dts/pxa910.dtsi
> +++ b/arch/arm/boot/dts/pxa910.dtsi
> @@ -54,6 +54,80 @@
> reg = <0xd4000000 0x00200000>;
> ranges;
>
> + pmx: pinmux at d401e000 {
> + compatible = "pinconf-single";
> + reg = <0xd401e000 0x0330>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + pinctrl-single,register-width = <32>;
> + pinctrl-single,function-mask = <7>;
And then..
> + pinctrl-single,power-source-mask = <0x1800>;
> + pinctrl-single,bias-mask = <0xe000>;
> + pinctrl-single,bias-disable = <0>;
> + pinctrl-single,bias-pull-down = <0xa000>;
> + pinctrl-single,bias-pull-up = <0xc000>;
> + pinctrl-single,input-schmitt-mask = <0x70>;
..remove these from here. Otherwise pinctrl-single,bits type controllers
won't be able to use the pinconf functions as we can have multiple pins
supported in a single register.
Regards,
Tony
More information about the linux-arm-kernel
mailing list