[PATCH 2/5] ARM: AT91SAM9G45: same platform data structure for all crypto peripherals
Eric Bénard
eric at eukrea.com
Wed Nov 7 10:50:26 EST 2012
Hi Jean-Christophe,
Le Wed, 7 Nov 2012 16:26:15 +0100,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> a écrit :
> > @@ -1931,9 +1931,9 @@ static struct platform_device at91sam9g45_aes_device = {
> > static void __init at91_add_device_aes(void)
> > {
> > struct at_dma_slave *atslave;
> > - struct aes_dma_data *alt_atslave;
> > + struct crypto_dma_data *alt_atslave;
> >
> > - alt_atslave = kzalloc(sizeof(struct aes_dma_data), GFP_KERNEL);
> > + alt_atslave = kzalloc(sizeof(struct crypto_dma_data), GFP_KERNEL);
> we do not check the result of kzalloc ouch
>
> and why we allocate it?
>
for both remarks : that's the way it's done in at91_add_device_mci since
75305d768d296a07fd02df9af3e5de326df1c72e
A v2 will follow (and also a fix for at91_add_device_mci).
Eric
More information about the linux-arm-kernel
mailing list