[PATCH] ARM: setup_mm_for_reboot(): use flush_cache_louis()
Russell King - ARM Linux
linux at arm.linux.org.uk
Wed Nov 7 04:56:35 EST 2012
On Wed, Nov 07, 2012 at 09:51:06AM +0000, Will Deacon wrote:
> Wouldn't the L2 flush in this case be included with the code that turns off
> caching? For reboot, that's currently done in __sort_restart -- the cache
> flush in setup_mm_for_reboot is just to ensure that the idmap tables are
> visible to the hardware walker iirc.
Good point - but it does raise another issue. Why do we do this flush and
TLB invalidate afterwards in setup_mm_for_reboot() ? It makes sense if
we change existing page tables, but we don't anymore, we're just switching
them, and cpu_switch_mm() will do whatever's necessary to make the new
page tables visible. So I think we can get rid of that flusing in there.
More information about the linux-arm-kernel
mailing list