[PATCH 1/3] ARM: OMAP4: VC: fix I2C timing

[Tero Kristo]

On Tue, 2012-05-29 at 14:30 -0700, Kevin Hilman wrote:
> Tero Kristo <t-kristo at ti.com> writes:
> 
> > Current I2C timing parameters do not work with Panda board at least.
> > Parameters updated based on TI recommendation.
> >
> > Signed-off-by: Tero Kristo <t-kristo at ti.com>
> 
> Let's fix this correctly by deriving/calculating them from the proper
> source clocks.

Hmm, I'll double check if these can actually be calculated or not.

-Tero

> 
> Otherwise, this is going to work for Panda and break for something else.
> 
> Kevin
> 
> > ---
> >  arch/arm/mach-omap2/vc.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> > index 1fd976e..a731400 100644
> > --- a/arch/arm/mach-omap2/vc.c
> > +++ b/arch/arm/mach-omap2/vc.c
> > @@ -585,7 +585,9 @@ static void __init omap4_vc_init_channel(struct voltagedomain *voltdm)
> >  	omap4_set_timings(voltdm, true);
> >  
> >  	/* XXX These are magic numbers and do not belong! */
> > -	vc_val = (0x60 << OMAP4430_SCLL_SHIFT | 0x26 << OMAP4430_SCLH_SHIFT);
> > +	vc_val = (0x28 << OMAP4430_SCLL_SHIFT | 0x2c << OMAP4430_SCLH_SHIFT);
> > +	vc_val |= (0x0b << OMAP4430_HSSCLL_SHIFT);
> > +	vc_val |= (0x0 << OMAP4430_HSSCLH_SHIFT);
> >  	voltdm->write(vc_val, OMAP4_PRM_VC_CFG_I2C_CLK_OFFSET);
> >  }