[PATCHv2 09/19] ARM: OMAP4: PM: add errata support

[Tero Kristo]

On Tue, 2012-05-29 at 15:10 -0500, Menon, Nishanth wrote:
> On Mon, May 14, 2012 at 5:18 AM, Tero Kristo <t-kristo at ti.com> wrote:
> > Added similar PM errata flag support as omap3 has. A few errata flags
> > will be added in subsequent patches.
> 
> Considering that we might have erratas for future SoCs as well,
> should'nt we just
> set up a common errata flag for all SoCs and since we have i123 numbers, would
> it help being able to reuse errata flags cross SoC generations (if we need to)?

Not sure... how quickly do we run out of bits that way? :) Also, at
least pm34xx / pm44xx erratas don't have anything in common. We can
probably re-use pm44xx erratas for omap5 though.

One annoyance is that, the OMAP4 erratas are going to have a number of
ROM code erratas on them, which don't really have any public i123
numbers available. >.<

-Tero

> 
> > Signed-off-by: Tero Kristo <t-kristo at ti.com>
> > ---
> >  arch/arm/mach-omap2/pm.h     |    7 +++++++
> >  arch/arm/mach-omap2/pm44xx.c |    1 +
> >  2 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> > index ce1e27f..e53ee3c 100644
> > --- a/arch/arm/mach-omap2/pm.h
> > +++ b/arch/arm/mach-omap2/pm.h
> > @@ -130,6 +130,13 @@ extern void enable_omap3630_toggle_l2_on_restore(void);
> >  static inline void enable_omap3630_toggle_l2_on_restore(void) { }
> >  #endif         /* defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP3) */
> >
> > +#if defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP4)
> > +extern u16 pm44xx_errata;
> > +#define IS_PM44XX_ERRATUM(id)          (pm44xx_errata & (id))
> > +#else
> > +#define IS_PM44XX_ERRATUM(id)          0
> > +#endif
> > +
> >  #ifdef CONFIG_OMAP_SMARTREFLEX
> >  extern int omap_devinit_smartreflex(void);
> >  extern void omap_enable_smartreflex_on_init(void);
> > diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
> > index 8f0ec56..8238097 100644
> > --- a/arch/arm/mach-omap2/pm44xx.c
> > +++ b/arch/arm/mach-omap2/pm44xx.c
> > @@ -35,6 +35,7 @@ struct power_state {
> >  };
> >
> >  static LIST_HEAD(pwrst_list);
> > +u16 pm44xx_errata;
> >
> >  #ifdef CONFIG_SUSPEND
> >  static int omap4_pm_suspend(void)
> > --
> > 1.7.4.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> 
> Regards,
> Nishanth Menon