[rtc-linux] [PATCH 17/22] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ

Linus Walleij linus.walleij at linaro.org
Wed May 30 03:11:51 EDT 2012


On Wed, May 30, 2012 at 12:47 PM, Lee Jones <lee.jones at linaro.org> wrote:

> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
>
> Cc: Alessandro Zummo <a.zummo at towertech.it>
> Cc: rtc-linux at googlegroups.com
> Signed-off-by: Lee Jones <lee.jones at linaro.org>
> ---
>  drivers/rtc/rtc-ab8500.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 4bcf9ca..b11a2ec 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -422,7 +422,7 @@ static int __devinit ab8500_rtc_probe(struct platform_device *pdev)
>        }
>
>        err = request_threaded_irq(irq, NULL, rtc_alarm_handler,
> -               IRQF_NO_SUSPEND, "ab8500-rtc", rtc);
> +               IRQF_NO_SUSPEND | IRQF_ONESHOT, "ab8500-rtc", rtc);
>        if (err < 0) {
>                rtc_device_unregister(rtc);
>                return err;

Looks correct, Acked-by (also for the previous patch).

Linus Walleij



More information about the linux-arm-kernel mailing list