[PATCH 16/22] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ

Linus Walleij linus.walleij at linaro.org
Wed May 30 03:10:28 EDT 2012


On Wed, May 30, 2012 at 12:47 PM, Lee Jones <lee.jones at linaro.org> wrote:

> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
>
> Cc: Samuel Ortiz <sameo at linux.intel.com>
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones at linaro.org>
> ---
>  drivers/mfd/ab8500-gpadc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> index c39fc71..358d502 100644
> --- a/drivers/mfd/ab8500-gpadc.c
> +++ b/drivers/mfd/ab8500-gpadc.c
> @@ -599,7 +599,8 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev)
>        /* Register interrupt  - SwAdcComplete */
>        ret = request_threaded_irq(gpadc->irq, NULL,
>                ab8500_bm_gpswadcconvend_handler,
> -               IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc", gpadc);
> +               IRQF_ONESHOT | IRQF_NO_SUSPEND | IRQF_SHARED,
> +                               "ab8500-gpadc", gpadc);

Looks correct to me I think this one should be ONESHOT anyway.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list