[PATCH] PINCTRL: SiRF: add CSR SiRFprimaII GPIO driver depending on pinmux APIs

[Barry Song]

Hi Linus,

2012/5/29 Linus Walleij <linus.walleij at linaro.org>:
> On Mon, May 28, 2012 at 11:03 PM, Barry Song <21cnbao at gmail.com> wrote:
>> 2012/5/24 Linus Walleij <linus.walleij at linaro.org>:
>
>>> This is actually such a nice and clean cut that it can be put into
>>> drivers/gpio, it's just using pinctrl, not sharing code or hardware
>>> registers with it. (If I understand correctly.)
>>
>> it is actually one pinmux/gpio/irq controller. as you see, i am using
>> the same dt node with pinctrl-sirf.c:
>> static const struct of_device_id sgpio_of_match[] __devinitconst = {
>>       {.compatible = "sirf,prima2-gpio-pinmux", },
>>       {},
>> };
>>
>> here i splitted into two files just for viewing, and at the same time,
>> i remap the same memory twice in pinctrl-sirf.c and gpio-sirf.c. they
>> share same memory area.
>
> Hmmmm.... but do they ever write into the same registers?

they share the same IOMEM area, but gpio set registers have different
offset with pinmux. is there any difference between writing same
registers and writing different registers? mainly, they are from the
same hardware controller.

>
>> these codes might be in pinctrl-sirf.c directly?
>
> That also works. If you want one hardware block to be handled by
> one driver you should do that. But if the split version works you
> can also do that, so I'm not sure.
>
> Yours,
> Linus Walleij

Thanks
barry