[PATCH] MXS: Add DENX M28 dts file

Marek Vasut marex at denx.de
Mon May 28 12:30:23 EDT 2012


Dear Fabio Estevam,

> Hi Marek,
> 
> On Sat, May 26, 2012 at 11:12 PM, Marek Vasut <marex at denx.de> wrote:
> > +       sound {
> > +               compatible = "fsl,imx28-evk-sgtl5000",
> > +                            "fsl,mxs-audio-sgtl5000";
> > +               model = "imx28-evk-sgtl5000";
> > +               saif-controllers = <&saif0 &saif1>;
> > +               audio-codec = <&sgtl5000>;
> > +       };
> > +};
> 
> Shouldn't this be:
> 
> sound {
> 	compatible = "fsl,imx28-m28-sgtl5000",
> 		     "fsl,mxs-audio-sgtl5000";

Wait, no ... it should not, why should it? (I'm still very lame with this device 
tree stuff, so any advice is very welcome)

> 	model = "imx28-m28-sgtl5000";
> 	saif-controllers = <&saif0 &saif1>;
> 	audio-codec = <&sgtl5000>;
> };

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list