[PATCH v3 05/12] usb: chipidea: add imx platform driver

Alexander Shishkin alexander.shishkin at linux.intel.com
Fri May 25 04:37:26 EDT 2012


Richard Zhao <richard.zhao at freescale.com> writes:

> This patch supports only the host-mode functionality so far.
>
> Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Peter Chen <peter.chen at freescale.com>
> Cc: Alexander Shishkin <alexander.shishkin at linux.intel.com>
> Cc: Felipe Balbi <balbi at ti.com>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>  .../devicetree/bindings/usb/ci13xxx-imx.txt        |   20 ++
>  drivers/usb/chipidea/Makefile                      |    3 +
>  drivers/usb/chipidea/ci13xxx_imx.c                 |  189 ++++++++++++++++++++

One comment: I was going to suggest dropping "13xxx" suffix from
everywhere in the driver, maybe module names too, since it doesn't
really add any value and people often mistype it, so maybe for the new
code it makes sense to avoid it? ci-imx looks better than ci13xxx-imx
anyway and same goes for ci_imx_probe() vs ci13xxx_imx_probe().
Does this make sense to you?

Regards,
--
Alex



More information about the linux-arm-kernel mailing list