[PATCH v3 2/2] regulator: Add support for MAX77686.

jonghwa3.lee at samsung.com jonghwa3.lee at samsung.com
Tue May 22 21:50:13 EDT 2012


Hi, again.
On 2012년 05월 22일 14:57, yadi.brar01 at gmail.com wrote:


> +static __devinit int max77686_pmic_probe(struct platform_device *pdev)
> +{

> +
> +	for (i = 0; i < pdata->num_regulators; i++) {
> +		config.dev = max77686->dev;
> +		config.init_data = pdata->regulators[i].init_data;
> +		config.driver_data = max77686;
> +		config.regmap = iodev->regmap;
> +
> +		rdev[i] = regulator_register(&regulators[i], &config);


I'm sorry that i missed one. You have to register all regulators
unconditionally. Mark brown commented about this to my former patch.

'No, you should unconditionally register all regulators the device
physically has.  This is useful for debug and simplifies the code.'
						- from Mark Brown



Thanks.



More information about the linux-arm-kernel mailing list