[PATCH v2 05/12] usb: chipidea: add imx driver binding

[Alexander Shishkin]

Richard Zhao <richard.zhao at freescale.com> writes:

> +#include "ci.h"
> +
> +#define PORT0_STATUS	0x184

This doesn't seem to be used anywhere.

[snip]
> +	ci13xxx_imx_udc_driver.phy = data->phy;

See my comment to the other patch about phy pointer being a per-device
thing rather then per-platform driver. Now, (at the risk of being
flamed) I think it could work if you allocated the
ci13xxx_imx_udc_driver dynamically in every probe, but that's not what
you want to do for the actual platform data. So, I suggest we come up
with a better way of passing phy to the driver. I also think that it's
really about time we renamed "struct ci13xxx_udc_driver" to something
that emphasizes the "platform" in it. What do you think?

Regards,
--
Alex