[PATCH] arm: Add basic support for new Marvell Armada SoC family

Andrew Lunn andrew at lunn.ch
Mon May 21 13:27:34 EDT 2012


On Mon, May 21, 2012 at 11:39:22AM -0400, Jason Cooper wrote:
> On Mon, May 21, 2012 at 11:40:52AM +0200, Andrew Lunn wrote:
> > > Personally, my view is leave it alone and just add a new machine
> > > directory.
> 
> I agree, see my response to Russell.
> 
> > > Pushing items around doesn't really help the amount of code in the
> > > kernel, the organisation does not add more than a line or two to the
> > > Makefiles.
> > 
> > It does however make it easier to see where the same code has been
> > cut/paste. There is some stuff in the various Orion mach- directories
> > which is repeated 4 times. The Armada XP port wanted to add a 5th
> > copy. All this repeated code needs to be put into plat-orion.
> 
> Does my suggested layout/migration path cover your concerns?

I actually like Arnd patch of putting everything into one
directory. I've been building on that patch removing duplicate code,
modifying the address map to make it as similar as possible, removing
defines which are the same on all SoCs etc. I think actually having
everything spread out is what has contributed to the X copies and
needless incompatibilities.

My vote is to commit Arnd patch as is.

   Andrew



More information about the linux-arm-kernel mailing list