[PATCH 1/4] GPMI-NAND: Define ecc.strength

Marek Vasut marex at denx.de
Sun May 20 23:48:00 EDT 2012


Dear Huang Shijie,

> 于 2012年05月21日 10:40, Marek Vasut 写道:
> > I doubt so ... but noone ever could test it without DT bindings as you
> > NAKed/stalled every single attempt to add the platform binding code. So
> > this code was rotting in the tree, who knows how many bugs are still in
> > it. Now I guess it's about time to start squashing the bugs.
> 
> I checked the latest l2-mtd code. The bug does exit if the gpmi-nand
> driver can works(actually it can not).

There's also the bug where you need to put gpmi at 8000c000 into the DTS file 
instead of gpmi-nand at 8000c000 ... maybe you should fix it?

Also, there's still the bug with subpage write size, "GPMI-NAND: Wrong ECC size 
in driver" thread in linux-mtd. That thread kind of died, but gpmi-nand is still 
broken in that way, it's depending on loose end of the mtd stack there. Won't 
hurt fixing that too, there was even a fix proposed.

> 
> I will test your patch.
> Anyway, this patch should be sent to Artem, not the arm-soc.

Resent, fixed, sorry for the inconvenience.

> 
> thanks
> Huang Shijie

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list