[PATCH v2] gpio/generic: initialize basic_mmio_gpio shadow variables properly

Grant Likely grant.likely at secretlab.ca
Sun May 20 02:00:02 EDT 2012


On Sat, May 19, 2012 at 8:10 PM, Shawn Guo <shawn.guo at freescale.com> wrote:
> On Sat, May 19, 2012 at 12:12:42PM -0600, Grant Likely wrote:
>> On Sat, 19 May 2012 16:55:51 +0800, Shawn Guo <shawn.guo at linaro.org> wrote:
>> > It fixes the issue in gpio-generic that commit fb14921 (gpio/mxc: add
>> > missing initialization of basic_mmio_gpio shadow variables) manged to
>> > fix in gpio-mxc driver, so that other platform specific drivers do not
>> > suffer from the same problem over and over again.
>> >
>> > Changes since v1:
>> > * Turn the last parameter "bool big_endian" into "unsigned long flags"
>> >   and give those really quirky hardwares a chance to tell that reg_set
>> >   and reg_dir are unreadable.
>> >
>> > Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
>>
>> Applied, thanks.
>>
> Grant,
>
> Can you please pick up the RESEND version of the patch, which had
> bgpio_pdev_probe adapt bgpio_init parameter change too?

I did even though I replied to the original..  You can check my
gpio/next branch to be sure.

g.



More information about the linux-arm-kernel mailing list