[PATCH] ARM: OMAP2+: fix gpmc request_irq

Shilimkar, Santosh santosh.shilimkar at ti.com
Fri May 18 03:03:16 EDT 2012


+ Afzal who has been doing quite a bit of GMPC work recently.

On Fri, May 18, 2012 at 10:13 AM, Ming Lei <ming.lei at canonical.com> wrote:
> The IRQ52 on OMAP2+ is not a shared interrupt line. If IRQF_SHARED
> is passed to request_irq and dev_id is set as NULL, request_irq will
> return -EINVAL.
>
GPMC IRQ line can shared between the multiple devices you
connect on it.

> This patch just removes the flag of IRQF_SHARED to make the irq
> registration successful.
>
> Cc: Kevin Hilman <khilman at ti.com>
> Cc: Tony Lindgren <tony at atomide.com>
> Signed-off-by: Ming Lei <ming.lei at canonical.com>
> ---
>  arch/arm/mach-omap2/gpmc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Are you sure it fails ?
I just tried booting OMAP4 with 3.4-rc4 and don't see the irq
failure error message. What I am missing ?

Regards
Santosh



More information about the linux-arm-kernel mailing list