[PATCHv2 04/19] ARM: OMAP4: PM: save/restore all DPLL settings in OFF mode

[Shilimkar, Santosh]

On Thu, May 17, 2012 at 4:12 AM, Kevin Hilman <khilman at ti.com> wrote:
> Tero Kristo <t-kristo at ti.com> writes:
>
>> From: Rajendra Nayak <rnayak at ti.com>
>>
>> SAR/ROM code restores only CORE DPLL to its original state
>> post wakeup from OFF mode.
>> The rest of the DPLL's in OMAP4 platform (MPU/IVA/ABE/USB/PER)
>> are saved and restored here during an OFF transition.
>>
>> [nm at ti.com: minor cleanups]
>> Signed-off-by: Nishanth Menon <nm at ti.com>
>> Signed-off-by: Rajendra Nayak <rnayak at ti.com>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
>> Signed-off-by: Tero Kristo <t-kristo at ti.com>
>
> Some general comments:
>
> - the register dump/print doesn't belong here.  If needed, should be a
>  debug feature if needed.
>
> - Rather than hooking into omap4_enter_lowpower(), should use
>  the cluster PM enter/exit notifier chain.
>
This is again specific to device OFF only and not related to CPU
cluster state as such. So I don't think notifiers should be used here.

O.w even when we attempt just MPU OSWR C-state, all these functions will
get called in notifier chain.

Regards
Santosh