[PATCH] gpio/generic: initialize the shadow of direction register

[Shawn Guo]

On Wed, May 16, 2012 at 04:03:51PM +0200, Lothar Waßmann wrote:
> _You_ want to introduce a change that will change the behaviour of
> existing code, so it's _your_ responsibility to make sure that your
> change doesn't break other users.
> 
> Those are the current users of bgpio:
> ./drivers/gpio/gpio-sodaville.c:        ret = bgpio_init(&sd->bgpio, &pdev->dev, 4,
> ./drivers/gpio/gpio-ep93xx.c:   err = bgpio_init(bgc, dev, 1, data, NULL, NULL, dir, NULL, false);
> ./drivers/gpio/gpio-mxc.c:      err = bgpio_init(&port->bgc, &pdev->dev, 4,
> ./drivers/gpio/gpio-mxs.c:      err = bgpio_init(&port->bgc, &pdev->dev, 4,
> 
> You should at least CC: their maintainers to inform them that the code
> they are relying on will change its behaviour.
> 
Yeah, considering it's impossible for me to test the change on all
those hardwares, that's the only thing I can do.  Thanks for pointing
those users to me.

-- 
Regards,
Shawn