[PATCH v1 4/7] usb: chipidea: add imx driver binding

Alexander Shishkin alexander.shishkin at linux.intel.com
Wed May 16 10:18:47 EDT 2012


Richard Zhao <richard.zhao at freescale.com> writes:

> On Wed, May 16, 2012 at 02:38:44PM +0300, Alexander Shishkin wrote:
>> > +	plat_ci = platform_device_alloc("ci_hdrc", (int)res->start);
>> 
>> Regarding the instance id here: you probably want to use something more
>> meaningful than the starting address. I was thinking about stealing id
>> allocator from Felipe's dwc3 (dwc3_get_device_id()), but decided to
>> first deal with more important things.
> hmm... Is dwc3_get_device_id() really meaningful than base address?
> It just record the sequence number.

Well, if you indeed have more than one controller, you might want to
know, for example, which one registered first. Or, one might simply not
like the look of "/sys/bus/platform/devices/ci_hdrc.-5898240".

Regards,
--
Alex



More information about the linux-arm-kernel mailing list