[PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller

[Lothar Waßmann]

Hi,

Artem Bityutskiy writes:
> On Tue, 2012-05-15 at 22:47 +0800, Josh Wu wrote:
> > +	while (!(pmerrloc_readl(host->pmerrloc_base, ELISR)
> > +		 & PMERRLOC_CALC_DONE))
> > +		cpu_relax();
> 
> How about some kind of time-out in something goes wrong?
> 
> > +		dev_warn(host->dev, "Only 2048 page size is currently " \
> > +			"supported for PMECC, rolling back to Software ECC\n");
> 
> Why do you use backslashes?
> 
message text should not be split across lines anyway to ease grepping
for the message.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________