[PATCH] gpio/generic: initialize the shadow of direction register

Shawn Guo shawn.guo at freescale.com
Wed May 16 03:29:00 EDT 2012


On Wed, May 16, 2012 at 08:53:42AM +0200, Lothar Waßmann wrote:
> > @@ -394,6 +394,10 @@ int bgpio_init(struct bgpio_chip *bgc, struct device *dev,
> >                 return ret;
> > 
> >         bgc->data = bgc->read_reg(bgc->reg_dat);
> > +       if (bgc->gc.set == bgpio_set_set)
> > +               bgc->data = bgc->read_reg(bgc->reg_set);
> > +       if (bgc->reg_dir)
> > +               bgc->dir = bgc->read_reg(bgc->reg_dir);
> > 
> >         return ret;
> >  }
> > 
> That might change the behaviour of existing implementations.
> 
Can you be specific?  I do not quite follow on that.

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list