[PATCH v1 2/7] usb: chipidea: remove zero check of hw_ep_max
Marek Vasut
marex at denx.de
Tue May 15 21:11:07 EDT 2012
Dear Richard Zhao,
> It's 0 for host only device.
>
> Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
> ---
> drivers/usb/chipidea/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index f568b8e..15e03b3 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -195,7 +195,7 @@ static int hw_device_init(struct ci13xxx *ci, void
> __iomem *base) ffs_nr(DCCPARAMS_DEN);
> ci->hw_ep_max = reg * 2; /* cache hw ENDPT_MAX */
>
> - if (ci->hw_ep_max == 0 || ci->hw_ep_max > ENDPT_MAX)
> + if (ci->hw_ep_max > ENDPT_MAX)
Well, maybe this check should be extended a bit? Let me send a subsequent patch
in reply to this, see what you think about it?
> return -ENODEV;
>
> dev_dbg(ci->dev, "ChipIdea HDRC found, lpm: %d; cap: %p op: %p\n",
Best regards,
Marek Vasut
More information about the linux-arm-kernel
mailing list