[PATCH 6/8] arm: mach-armada: add support for Armada XP board with device tree

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue May 15 10:16:55 EDT 2012


Le Tue, 15 May 2012 14:53:45 +0100,
Ben Dooks <ben.dooks at codethink.co.uk> a écrit :

> Since the two board support files are identical, except for the names
> they print, I'd say this is the job of one file. It can always be
> split later.

The initial motivation for keeping two files here is that the two SoC
have a different number of PCIe memory areas, and those areas are
typically mapped in ->map_io(). However:

 * Maybe those mappings can be done using a normal ioremap() rather
   than in ->map_io(), according to DT informations (but most other ARM
   SoC support at the moment seem to do PCI mappings using static
   mappings in ->map_io)

 * We probably shouldn't have anticipated this too much, and keep only
   one file for this initial submission.

We'll rework this for our v2.

Thanks for the comments!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list