[PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

Kevin Hilman khilman at ti.com
Mon May 14 18:24:11 EDT 2012


Vaibhav Hiremath <hvaibhav at ti.com> writes:

> From: Kevin Hilman <khilman at ti.com>
>
> There are certain fields inside 'struct dpll_data' which are
> included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> difficult to use it for new devices like, am33xx, ti81xx, etc...
>
> So remove the ifdef completely, this will add few fields to the struct
> unused, but it improves readability and maintainability of the code.
>
> Signed-off-by: Kevin Hilman <khilman at ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav at ti.com>
> Cc: Tony Lindgren <tony at atomide.com>
> Cc: Paul Walmsley <paul at pwsan.com>
> Cc: Santosh Shilimkar <santosh.shilimkar at ti.com>
> Cc: R Sricharan <r.sricharan at ti.com>
> ---
> Since Kevin had provided this idea and code change,
> making this patch under his authorship.

Be sure to give yourself credit for writing the changelog.  Normally, if
you make changes/additions to patch, you can add a line just before your
signoff.  Something like:

[hvaibhav at ti.com: wrote detailed changelog]

Kevin




More information about the linux-arm-kernel mailing list