[PATCH] ARM: EXYNOS: fix the hotplug for Cortex-A15

Olof Johansson olof at lixom.net
Sun May 13 00:15:11 EDT 2012


Hi,

As mentioned in your earlier git pull request:

On Wed, May 9, 2012 at 5:37 AM, Kukjin Kim <kgene.kim at samsung.com> wrote:
> From: Changhwan Youn <chaos.youn at samsung.com>
>
> The sequence of cpu_enter_lowpower() for Cortex-A15
> is different from the sequence for Cortex-A9.
> This patch implements cpu_enter_lowpower() for EXYNOS5
> SoC which has Cortex-A15 cores.
>
> Signed-off-by: Changhwan Youn <chaos.youn at samsung.com>
> Cc: Russell King <rmk+kernel at arm.linux.org.uk>
> Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> ---
> Note, I didn't see common code for fix of hotplug for Cortex-A15.
> If any regarding patch, please kindly let me know, thanks.
>
>  arch/arm/mach-exynos/hotplug.c |   39 +++++++++++++++++++++++++++++++++++++--
>  1 files changed, 37 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
> index 9c17a0a..2a444b1 100644
> --- a/arch/arm/mach-exynos/hotplug.c
> +++ b/arch/arm/mach-exynos/hotplug.c

[..]
> @@ -112,7 +143,11 @@ void platform_cpu_die(unsigned int cpu)
>        /*
>         * we're ready for shutdown now, so do it
>         */
> -       cpu_enter_lowpower();
> +       if (soc_is_exynos5250())
> +               cpu_enter_lowpower_a15();
> +       else
> +               cpu_enter_lowpower_a9();
> +

This should be done by checking for the actual CPU in the system
instead of which SoC it is running on, otherwise you will need to over
time grow this list of SoCs that happen to have A15.


-Olof



More information about the linux-arm-kernel mailing list