[PATCH 1/4] ARM: OMAP2+: Introduce CONFIG_SOC_HAS_OMAP_DPLL macro

R, Sricharan r.sricharan at ti.com
Fri May 11 02:16:32 EDT 2012


Vaibhav,
[snip]
>> diff --git a/arch/arm/plat-omap/include/plat/clock.h b/arch/arm/plat-omap/include/plat/clock.h
>> index d0ef57c..095bee8 100644
>> --- a/arch/arm/plat-omap/include/plat/clock.h
>> +++ b/arch/arm/plat-omap/include/plat/clock.h
>> @@ -156,7 +156,7 @@ struct dpll_data {
>>       u8                      min_divider;
>>       u16                     max_divider;
>>       u8                      modes;
>> -#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
>> +#ifdef CONFIG_SOC_HAS_OMAP_DPLL
>>       void __iomem            *autoidle_reg;
>>       void __iomem            *idlest_reg;
>>       u32                     autoidle_mask;
>> @@ -167,7 +167,7 @@ struct dpll_data {
>>       u8                      auto_recal_bit;
>>       u8                      recal_en_bit;
>>       u8                      recal_st_bit;
>> -#  endif
>> +#endif
>
> I had submitted similar patch recently, and Kevin had suggested that
> Instead of adding config option, we shoule simply get rid of this ifdef
> completely.
>
> Refer to
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg68293.html
>
>
> Waiting for Paul to conform here.
>
 Thanks for pointing that out. Will check on this and Paul's PRCM series
 cleanup series then.

Thanks,
 Sricharan



More information about the linux-arm-kernel mailing list