[PATCH 01/13] ARM: OMAP5: id: Add cpu id for ES versions

R, Sricharan r.sricharan at ti.com
Thu May 10 09:15:52 EDT 2012


Hi J,

> why do you duplicate this
>> +                     break;
>> +             case 1:
>> +                     omap_revision = OMAP5430_REV_ES2_0;
>> +                     break;
> do this
>
>                case 0:
>> +             default:
>> +                     omap_revision = OMAP5430_REV_ES1_0;
>> +             }
>> +             break;
>> +
>> +     case 0xb998:
>> +             switch (rev) {
>> +             case 0:
>> +                     omap_revision = OMAP5432_REV_ES1_0;
>> +                     break;
>> +             default:
> ditto here

   Agree. Will correct the redundancy.

Thanks,
 Sricharan



More information about the linux-arm-kernel mailing list