[PATCH 2/2] regulator: Add support for MAX77686.

[Yadwinder Singh Brar]

Hi  Sylwester,

On Thu, May 10, 2012 at 1:24 AM, Sylwester Nawrocki <snjw23 at gmail.com> wrote:
> Hi,
>
> just a few nitpicks...
>
>
> On 05/09/2012 06:24 PM, Yadwinder Singh wrote:
>>
>> From: Yadwinder Singh Brar<yadi.brar at samsung.com>
>>
>> Add support for PMIC/regulator portion of MAX77686 multifunction device.
>> MAX77686 provides LDOs[1-26] and BUCKs[1-9]. This is initial release of
>> driver
>> which supports setting and getting the voltage of a regulator with I2C
>> interface.
>>
>> Signed-off-by: Yadwinder Singh Brar<yadi.brar at samsung.com>
>
> ...
>
>> diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
>> new file mode 100644
>> index 0000000..4aa9722
>> --- /dev/null
>> +++ b/drivers/regulator/max77686.c
>> @@ -0,0 +1,660 @@
>> +/*
>> + * max77686.c - Regulator driver for the Maxim 77686
>> + *
>> + * Copyright (C) 2012 Samsung Electronics
>
>
> I believe this should read:
>
>  + * Copyright (C) 2012 Samsung Electronics Co., Ltd.
>
> In patch 1/2 the copyright notice is also not exactly correct.
>
>
>> + * Chiwoong Byun<woong.byun at smasung.com>
>
>
> s/smasung/samsung
>
> ...
>

Thanks for pointing. I will rectify above mistakes.

>> +static int max77686_get_enable_register(struct regulator_dev *rdev,
>> +                                       int *reg, int *mask, int *pattern)
>> +{
>> +       int rid = rdev_get_id(rdev);
>> +
>> +       switch (rid) {
>> +       case MAX77686_LDO1...MAX77686_LDO26:
>> +               *reg = MAX77686_REG_LDO1CTRL1 + (rid - MAX77686_LDO1);
>> +               *mask = 0xC0;
>> +               *pattern = 0xC0;
>
>
> What about using lower case for all hex numbers ?
>
> ...
>

Yes, i will take care of this.

>> +static int max77686_get_voltage_register(struct regulator_dev *rdev,
>> +                                        int *_reg, int *_shift, int
>> *_mask)
>> +{
>
> ...
>
>> +       case MAX77686_BUCK2:
>> +               reg = MAX77686_REG_BUCK2DVS1;
>> +               mask = 0xff;
>> +               break;
>> +       case MAX77686_BUCK3:
>> +               reg = MAX77686_REG_BUCK3DVS1;
>> +               mask = 0xff;
>> +               break;
>> +       case MAX77686_BUCK4:
>> +               reg = MAX77686_REG_BUCK4DVS1;
>> +               mask = 0xff;
>> +               break;
>> +       case MAX77686_BUCK5...MAX77686_BUCK9:
>> +               reg = MAX77686_REG_BUCK5OUT + (rid - MAX77686_BUCK5) * 2;
>> +               break;
>> +       default:
>> +               return -EINVAL;
>> +       }
>> +
>> +       *_reg = reg;
>> +       *_shift = shift;
>> +       *_mask = mask;
>> +
>> +       return 0;
>> +}
>
>
> Thanks,
> Sylwester
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Thanks,
Yadwinder.