[PATCH 02/10] mmc: mxs-mmc: let ssp_is_old take host as parameter

Shawn Guo shawn.guo at linaro.org
Tue May 8 10:32:05 EDT 2012


On Tue, May 08, 2012 at 01:43:49AM +0200, Marek Vasut wrote:
> >  #define SSP_VERSION_LATEST	4
> > -#define ssp_is_old()		(host->version < SSP_VERSION_LATEST)
> > +#define ssp_is_old(host)	(host->version < SSP_VERSION_LATEST)
> 
> (host)->version ... to make the macro safer.
> 
Sounds good.

> > -	if ((stat & BM_SSP_CTRL1_SDIO_IRQ) && (stat & BM_SSP_CTRL1_SDIO_IRQ_EN))
> > +	if ((sta & BM_SSP_CTRL1_SDIO_IRQ) && (stat & BM_SSP_CTRL1_SDIO_IRQ_EN))
> 
> ^ s/sta/stat/ ... did you try compiling this at all ? :-)
> 
This is an error introduced by a last minute rebase.  Thanks for
catching it.  Fixed.

-- 
Regards,
Shawn



More information about the linux-arm-kernel mailing list