[PATCH] ARM: imx6q: make ksz9021rn_phy_fixup depends on config of FEC

Artem Bityutskiy dedekind1 at gmail.com
Tue May 8 09:47:29 EDT 2012


On Tue, 2012-05-08 at 21:21 +0800, Richard Zhao wrote:
> Fix build error without choose fec driver.
> 
> Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
Reported-by: Artem Bityutskiy <dedekind1 at gmail.com>

> +#if defined(CONFIG_FEC) || defined(CONFIG_FEC_MODULE)

I think there is a nicer way of doing this, something like

#include <linux/kconfig.h>

if (IS_ENABLED(CONFIG_FEC)) {
}

and you do not need the #ifdef ugliness.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120508/fa5b32e3/attachment-0001.sig>


More information about the linux-arm-kernel mailing list