[PATCH v2 1/3] omap: mailbox: enable mailbox irq per instance

Ohad Ben-Cohen ohad at wizery.com
Tue May 8 05:43:41 EDT 2012


Hi Juan,

On Tue, May 8, 2012 at 1:09 AM, Gutierrez, Juan <jgutierrez at ti.com> wrote:
> Startup it is now only used to enable pm runtime of the whole mbox module.

Btw I really doubt we need to do that in a machine-specific handler,
or whether we really need this startup/shutdown abstraction at all.
But that's not related to your patch of course...

> I think, if request_irq is called from the generic layer, it is kind
> of logical to enable_irq next to it.

I somewhat agree, though I was wondering about the implications for
OMAP1, which didn't seem to enable_irq at startup at all. Not sure
there's much to do here (unless you have some OMAP1 hardware ? :).

Thanks,
Ohad.



More information about the linux-arm-kernel mailing list