[PATCH 2/2] ARM: mmp: add io head file

Arnd Bergmann arnd at arndb.de
Mon May 7 05:23:07 EDT 2012


On Monday 07 May 2012, Haojian Zhuang wrote:
> +#ifndef __ARCH_MMP_IO_H
> +#define __ARCH_MMP_IO_H
> +
> +#define IO_SPACE_LIMIT 0xffffffff
> +
> +#define __io(a)                ((a) & IO_SPACE_LIMIT)
> +
> +#endif

NAK

If you don't have ISA or PCI devices, don't define these.

More importantly, never define them to an incorrect value. This
definition will cause an oops by NULL pointer dereferences for any
access to ISA devices such as writing to /dev/port, or loading a
module that probes the ISA ports.

	Arnd



More information about the linux-arm-kernel mailing list