[PATCH 1/2] mfd: max8925: request resource region

[Mark Brown]

On Mon, May 07, 2012 at 08:58:00AM +0100, Russell King - ARM Linux wrote:
> On Mon, May 07, 2012 at 11:10:48AM +0800, Haojian Zhuang wrote:
> > If resource region isn't requested, component devices will fail to request
> > their resources.

> > Signed-off-by: Haojian Zhuang <haojian.zhuang at gmail.com>

> This looks wrong.

> This driver looks broken.  IO regions are for PC IO stuff, not for I2C
> buses.  There is no resource reservation system in the kernel for
> registers on I2C devices.

They've commonly been used for this, it's a fairly sane way for an MFD
to communicate with its subdevices.  The fix in this series isn't good,
though - providing a parent resource with a suitable range for all the
device resources should do the job much more sensibly.  This isn't great
but the infrastructure seems to do the right thing with it for now and
it only requires a bit of reinterpretation of what IORESOURCE_IO means.