[PATCH 1/2] mfd: max8925: request resource region

Haojian Zhuang haojian.zhuang at gmail.com
Mon May 7 04:18:40 EDT 2012


On Mon, May 7, 2012 at 3:58 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Mon, May 07, 2012 at 11:10:48AM +0800, Haojian Zhuang wrote:
>> If resource region isn't requested, component devices will fail to request
>> their resources.
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang at gmail.com>
>
> This looks wrong.
>
> This driver looks broken.  IO regions are for PC IO stuff, not for I2C
> buses.  There is no resource reservation system in the kernel for
> registers on I2C devices.

There's some components in PMIC devices. I used IO resources to
identify these components,
and these IO resources are register offset in PMIC. But if I choose
MEM resources, it may
conflict with real memory resources. So I choose IO resources. Do you
have any other implementation
instead?

Thanks
Haojian



More information about the linux-arm-kernel mailing list