[PATCH] gpio: Add simple poweroff-gpio driver
Andrew Lunn
andrew at lunn.ch
Thu May 3 06:26:55 EDT 2012
> >If you look at the Kirkwood/Orion5x, most systems that could use this
> >are currently not DT enabled. So i think it needs old style
> >platform_data as well as OF.
>
> I wondered about this, but if you have board support code instead of
> devicetree, would you have any reasons to use this driver over just
> implementing the pm_power_off as most of them currently do? Seemed
> to me that it was better to not complicate the code with
> platform_data when it's practical use wasn't that high.
I just see that we have the same board support code repeated X
times. We can replace it with a platform device structures. We can
also add a function to create these structures, so in the end, we have
a one-liner in the board support code.
Andrew
More information about the linux-arm-kernel
mailing list