[PATCH 3/4] ARM: Exynos5: Fix incorrect initialization of GIC
Kukjin Kim
kgene.kim at samsung.com
Wed Mar 28 21:46:09 EDT 2012
Thomas Abraham wrote:
> Use the of_irq_init() call to setup the gic which also properly registers
> the gic device node pointer with gic irq domain, without which all interrupt
> specifier translations for gic fail.
>
> Signed-off-by: Thomas Abraham<thomas.ab at samsung.com>
> ---
> arch/arm/mach-exynos/common.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index f265dc4..3bf39a8 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -542,7 +542,7 @@ void __init exynos5_init_irq(void)
> {
> int irq;
>
> - gic_init(0, IRQ_PPI(0), S5P_VA_GIC_DIST, S5P_VA_GIC_CPU);
> + of_irq_init(exynos4_dt_irq_match);
>
> for (irq = 0; irq< EXYNOS5_MAX_COMBINER_NR; irq++) {
> combiner_init(irq, (void __iomem *)S5P_VA_COMBINER(irq),
Yes, right. The of_irq_init() shold be used instead. But I need to check
about the usage of SPI and if any updates, let you know :)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
More information about the linux-arm-kernel
mailing list