[PATCH] watchdog/coh901327: convert to use watchdog core

Linus Walleij linus.walleij at linaro.org
Thu Mar 22 14:09:15 EDT 2012


On Thu, Mar 22, 2012 at 3:49 PM, Wim Van Sebroeck <wim at iguana.be> wrote:

> I added it. Only issue left is that you don't set the timeout value properly.
> This will result in faulty values for the WDIOC_GETTIMEOUT iotcl.
> Furthermore margin should be unsigned int. And there is also no check to see
> if margin is a valid parameter after it is loaded as a module.
>
> Could you test attached patch?

I cannot test it right now because I'm out of reach for the hardware,
but it looks good to me so:
Acked-by: Linus Walleij <linus.walleij at linaro.org>

If I find any problems later I can surely fix them.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list