[PATCH 1/3] mmc: atmel-mci: correct data timeout computation

[Ludovic Desroches]

Hello Sergei,

On Wed, Mar 21, 2012 at 07:26:04PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 03/21/2012 06:41 PM, ludovic.desroches at atmel.com wrote:
> 
> >From: Ludovic Desroches<ludovic.desroches at atmel.com>
> 
> >The HSMCI operates at a rate of up to Master Clock divided by two.
> 
> >Signed-off-by: Ludovic Desroches<ludovic.desroches at atmel.com>
> >---
> >  drivers/mmc/host/atmel-mci.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> >diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> >index e4449a5..e161452 100644
> >--- a/drivers/mmc/host/atmel-mci.c
> >+++ b/drivers/mmc/host/atmel-mci.c
> >@@ -480,7 +480,7 @@ err:
> >  static inline unsigned int atmci_ns_to_clocks(struct atmel_mci *host,
> >  					unsigned int ns)
> >  {
> >-	return (ns * (host->bus_hz / 1000000) + 999) / 1000;
> >+	return (ns * ((host->bus_hz/2) / 1000000) + 999) / 1000;
> 
>    Why don't you keep the notation by addign spaces around '/'?
>    BTW, could use DIV_ROUND_UP() here.
> 

Thanks for your comments. BTW I have realized (when testing values return using
DIV_ROUND_UP) that I may have another issue with this timeout calculation.
I will send a new patch.

Regards

Ludovic