[PATCH v7 2/3] clk: introduce the common clock framework
Shawn Guo
shawn.guo at linaro.org
Sun Mar 18 10:07:10 EDT 2012
Another trivial comment. But if there is an incremental patch, maybe
consider to include it.
On Thu, Mar 15, 2012 at 11:11:19PM -0700, Mike Turquette wrote:
...
> +#ifdef CONFIG_COMMON_CLK_DISABLE_UNUSED
> +static int clk_disable_unused(void)
> +{
> + struct clk *clk;
> + struct hlist_node *tmp;
> +
> + mutex_lock(&prepare_lock);
> +
> + hlist_for_each_entry(clk, tmp, &clk_root_list, child_node)
> + clk_disable_unused_subtree(clk);
> +
> + hlist_for_each_entry(clk, tmp, &clk_orphan_list, child_node)
> + clk_disable_unused_subtree(clk);
> +
> + mutex_unlock(&prepare_lock);
> +
> + return 0;
> +}
> +late_initcall(clk_disable_unused);
> +#else
> +static inline int clk_disable_unused(struct clk *clk) { return 0; }
This #else block seems completely unnecessary to me.
> +#endif /* CONFIG_COMMON_CLK_DISABLE_UNUSED */
--
Regards,
Shawn
More information about the linux-arm-kernel
mailing list