[PATCH 10/10] ARM: ux500: Enable PL022 SSP Controller in Device Tree

Linus Walleij linus.walleij at linaro.org
Thu Mar 15 12:11:45 EDT 2012


On Wed, Mar 14, 2012 at 2:05 PM, Lee Jones <lee.jones at linaro.org> wrote:

> This SSP Controller supports a number of serial communication methods.
>
> Namely:
>
> /**
>  * enum ssp_interface - interfaces allowed for this SSP Controller
>  * @SSP_INTERFACE_MOTOROLA_SPI: Motorola Interface
>  * @SSP_INTERFACE_TI_SYNC_SERIAL: Texas Instrument Synchronous Serial
>  * interface
>  * @SSP_INTERFACE_NATIONAL_MICROWIRE: National Semiconductor Microwire
>  * interface
>  * @SSP_INTERFACE_UNIDIRECTIONAL: Unidirectional interface (STn8810
>  * &STn8815 only)
>  */
>
> ... and as such cannot be registered using of_register_spi_devices.
> Instead it can be registered simply as a primecell device.
>
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

Why is the commit message all about what the patch cannot do rather
than on what it does, anyway, begin with stating what you do and
its:
Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list