[PATCH v4] of: introduce helper to manage boolean

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Thu Mar 15 10:18:43 EDT 2012


On 03:54 Thu 15 Mar     , Grant Likely wrote:
> On Tue, 13 Mar 2012 18:48:23 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:
> > of_property_read_bool
> > 
> > Search for a property in a device node.
> > Returns true if the property exist false otherwise.
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > Acked-by: Rob Herring <rob.herring at calxeda.com>
> > Acked-by: Arnd Bergmann <arnd at arndb.de>
> 
> One comment below; but otherwise:
> 
> Acked-by: Grant Likely <grant.likely at secretlab.ca>
> 
> Feel free to merge via whatever tree needs it.
> 
> g.
> 
> > Cc: Grant Likely <grant.likely at secretlab.ca>
> > ---
> > v4:
> > 
> > 	send the right version
> > 
> > 	include Grant comment
> > 
> > 	Grant can I get the go please?
> > 
> > Best Regards,
> > J.
> >  include/linux/of.h |   16 ++++++++++++++++
> >  1 files changed, 16 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index a75a831..a992cdf 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -342,6 +342,22 @@ static inline int of_machine_is_compatible(const char *compat)
> >  #define of_match_node(_matches, _node)	NULL
> >  #endif /* CONFIG_OF */
> >  
> > +/**
> > + * of_property_read_bool - Findfrom a property
> > + * @np:		device node from which the property value is to be read.
> > + * @propname:	name of the property to be searched.
> > + *
> > + * Search for a property in a device node.
> > + * Returns true if the property exist false otherwise.
> > + */
> > +static inline bool of_property_read_bool(const struct device_node *np,
> > +					 const char *propname)
> > +{
> > +	struct property *prop = of_find_property(np, propname, NULL);
> > +
> > +	return prop ? true : false;
> > +}
> 
> Could simply be:
> {
> 	return of_find_property(...) != NULL;
ok fine no preference sned the pull to Arnd with the reset of the DT for at91

please check the USB too I gusee they can go too  but maybe  for the atmel
high-speed device you will have some comment

Best Regards,
J.



More information about the linux-arm-kernel mailing list